Closure: report missing function parameter typehint and missing return type · Issue #87

link管理

链接快照平台

输入网页链接，自动生成快照
标签化管理网页链接

相关文章推荐

灰常酷的鸡蛋 · 友盟+首席产品官 ...· 2 月前 ·

性感的钥匙扣 · 音乐之声观后感10篇-尊氪范文网· 3 月前 ·

暴走的火锅 · Spark or PySpark ...· 4 月前 ·

干练的围巾 · make oldconfig: ...· 10 月前 ·

曾经爱过的蜡烛 · 近鐵電車周遊券（KINTETSU RAIL ...· 1 年前 ·

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hi, I would like to enable for Closures the two rules already present for normal functions, MissingFunctionParameterTypehintRule and MissingFunctionReturnTypehintRule .

I found that master branch has this commit 491540d which already enabled PHPStan\Rules\Missing\MissingClosureNativeReturnTypehintRule , so I guess only the parameter typehint is still missing.

May I propose a PR for a MissingClosureParameterTypehintRule ?

Hi, the main blocker is that PHPStan currently does not read docblocks for closures. So things like union types or what’s in an array cannot be expressed for closures. We’d need to do that first and then adding such a rule would be easy. MissingClosureNativeReturnTypehintRule is a little bit different. It looks at what you’re returning from the function, and if it can be expressed with a native typehint, it asks you to do so.

On Thu, 22 Aug 2019 at 14:27, Filippo Tessarotto ***@***.***> wrote: Hi, I would like to enable for Closures the two rules already present for normal functions, MissingFunctionParameterTypehintRule and MissingFunctionReturnTypehintRule. I found that master branch has this commit 491540d < 491540d > which already enabled PHPStan\Rules\Missing\MissingClosureNativeReturnTypehintRule, so I guess only the parameter typehint is still missing. May I propose a PR for a MissingClosureParameterTypehintRule? You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub < #87 ?email_source=notifications&email_token=AAAZTOCUBETEUI6ULR7AO6TQF2A2DA5CNFSM4IOUMVPKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HGYWNSQ>, or mute the thread < https://github.com/notifications/unsubscribe-auth/AAAZTOC4F5PLHXZUK4LLXVLQF2A2DANCNFSM4IOUMVPA > Ondřej Mirtes

Ok then, I'll wait for a PR.

For those who don't want to wait, don't use docblocks for closures and don't handle mixed types, a simple rule like this can be added to the project:

https://github.com/Slamdunk/phpstan-extensions/blob/v3.6.0/lib/MissingClosureParameterTypehintRule.php