By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe the bug / provide steps to reproduce it

From time to time, if a custom keybinding uses space as a "leader key", the default behaviour will still occur, meaning that the custom keybinding will not fire correctly. For example, if the binding is "space o t" in order to focus the terminal panel, sometimes the default binding for space (which moves the cursor to the right by one character) is triggered, meaning that the other keys pressed (o and t) are fired as normal, which will create a new line and insert the letter t.

Environment

Zed: v0.121.1 (Zed Preview)
OS: macOS 14.0.0
Memory: 16 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.

No response

For me it seems to works perfectly on that pre-release: https://github.com/zed-industries/zed/releases/tag/v0.121.1-pre

Here is an example of my keymap: (I even test it too with space o t and it was working fine for me)

"context" : " Editor && vim_mode == normal && vim_operator == none && !VimWaiting " , "bindings" : { "space e" : " workspace::ToggleLeftDock " , "space t" : " workspace::ToggleBottomDock " , "space /" : [ " editor::ToggleComments " , "advance_downwards" : false "context" : " ProjectPanel " , "bindings" : { "escape" : " workspace::ToggleLeftDock " "context" : " Terminal " , "bindings" : { "cmd-n" : " workspace::NewTerminal " , "cmd-d" : " pane::CloseActiveItem " , "cmd-t" : " workspace::ToggleBottomDock " , "cmd-shift-f" : " workspace::ToggleZoom " , "escape" : " workspace::ToggleBottomDock "

Edit: It may always works for me because I always close my Panel/Terminal with escape to return the focus on my editor?

matching keybindings. It matches keybindings per context and if it finds a match on a lower context it doesn't keep pending keystrokes. If it finds two matches on the same context level, requiring more keystrokes, then it waits. Co-authored-by: Conrad <[email protected]> matching keybindings. It matches keybindings per context and if it finds a match on a lower context it doesn't keep pending keystrokes. If it finds two matches on the same context level, requiring more keystrokes, then it waits. Release Notes: - Fixed `cmd-k` in terminal taking 1s to have an effect. Also fixed sporadic non-matching of keybindings if there are overlapping keybindings. ([ #7270 ]( #7270 )). --------- Co-authored-by: Conrad <[email protected]> Co-authored-by: Conrad Irwin <[email protected]> matching keybindings. It matches keybindings per context and if it finds a match on a lower context it doesn't keep pending keystrokes. If it finds two matches on the same context level, requiring more keystrokes, then it waits. Release Notes: - Fixed `cmd-k` in terminal taking 1s to have an effect. Also fixed sporadic non-matching of keybindings if there are overlapping keybindings. ([ #7270 ]( #7270 )). --------- Co-authored-by: Conrad <[email protected]> Co-authored-by: Conrad Irwin <[email protected]> # Conflicts: # crates/gpui/src/window.rs