By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account Update wkhtmltopdf libraries to 0.12.5 and fix a callback was made on a garbage collected delegate bug Update wkhtmltopdf libraries to 0.12.5 and fix a callback was made on a garbage collected delegate bug rndusr0 wants to merge commits into rdvojmoc : master rndusr0 : master This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters

Show hidden characters

Great work on this, thank you, but not sure if this project is now dead? Thought I'd make another PR since my last one anyway, with a couple of updates and fixes:

Updated macOS and Linux wkhtmltopdf to 0.12.5 in addition to Windows in the last PR, removed 0.12.4 and updated nuget build

Fixed (I think!) 'A callback was made on a garbage collected delegate' issue - PdfTools should now hold a reference to any delegates in managed code so the GC doesn't collect them, thought this was probably best done in PdfTools rather than in the BasicConverter, so any other consumers of PdfTools shouldn't have to worry about this issue, but I could be wrong...

Added licence link to nuget package meta-data

If it's useful to anyone, I've published this as a nuget package at https://www.nuget.org/packages/RndUsr0.DinkToPdf/

It's only been tested on Windows, but any feedback gratefully received...

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.