Jython helper libraries for OH3 - Migration - openHAB Community

link管理

链接快照平台

输入网页链接，自动生成快照
标签化管理网页链接

相关文章推荐

俊逸的圣诞树 · 古董局中局1：佛头奇案（同名电影雷佳音、李现 ...· 6 月前 ·

忐忑的口罩 · Home - Silverhawk ...· 7 月前 ·

紧张的烤面包 · 鲁杰里：今晚的结果令人遗憾，我们必须进欧冠& ...· 8 月前 ·

打酱油的小蝌蚪 · Visualising large ...· 10 月前 ·

温柔的杨桃 · 浅谈iOS的多Window处理 | ...· 1 年前 ·

UPDATE : For OpenHAB 3+ Please use this fork instead: GitHub - CrazyIvan359/openhab-helper-libraries: JSR223-Jython scripts and modules for use with openHAB - it’s maintained and contains more updates and fixes.

I stumbled across a problem during upgrading to OH3 because there’s no jython helper libraries for OH3 yet. I have managed to make some quick and dirty modifications to the current helper libraries to make it work on OH3. One last change that I need to do in triggers.py is to replace the Quartz isValidExpression that validates a cron expression, because quartz is no longer included in OH3.

I see that in org.openhab.core.internal.scheduler there’s the CronAdjuster class that I could possibly use to validate the cron expression, however I cannot import this class into jython.

It’s late and I’m about to crash, but I thought I’d post it here to see if someone knows how to replace this isValidExpression. I can implement my own but would rather use an existing code that has been tested.

~~In the mean time, I’ve created a dummy isValidExpression returning True, and commenting out the some parts of triggers.py in the helper libraries.~~ I’ve created a rudimentary replacement for isValidExpression , which I will improve upon should it be necessary. At least my rules are working on OH3, after converting Joda datetime to ZonedDateTime .

EDIT: I have posted my working version on github here (note the oh3-patch branch):

github.com

It’s meant as a temporary fix until the official fix is available from @5iver .

All you need are these two directories:

Core/automation/jsr223/python/core

Core/automation/lib/python/core

Placed them into your conf/automation/(jsr223 | lib)/python/core correspondingly

The CronAdjuster is an internal class so it is not exported by the bundle. So I think the only way to currently use it is to copy/paste/port it… maybe some logic can be moved to an exported utility class so it can be more easily reused in the future. Based on the CronScheduler JavaDocs the cron expressions used by openHAB differ a bit to the Quartz cron expressions, so it may also prevent some issues.

I think for the purpose of triggers.py isValidExpression, I’ll just implement a simple regex check. Hopefully I’ll manage to fork and publish my modifications on github some time today so others can use it to get their jython rules up and running again, while waiting for @5iver to publish the official update.

Did you mean something like this?
https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/time/ZonedDateTime.html

Changing from Joda to ZonedDateTime seems straight forward:


     from org.joda.time import DateTime

→


     from java.time import ZonedDateTime


     DateTime.now()

→


     ZonedDateTime.now()


     .getHourOfDay()

→


     .getHour()


     .getMinuteOfHour()

→


     .getMinute()


     .plusMillis(x)

→ '.plusNanos(x * 1000000)`

and so on.

Alternatively, for even less change:

from java.time import ZonedDateTime as DateTime
Then you just need to change getHourOfDay etc to their equivalent methods of ZonedDateTime. Most of the other methods have the same name, e.g. plusMinutes().
              I detected another issue with the triggers: StartupTrigger is not working properly. By modifing the StartupTrigger class (around line 720 in triggers.py) I got it working:
Replace

self.trigger = TriggerBuilder.create().withId(trigger_name).withTypeUID("jsr223.StartupTrigger").withConfiguration(Configuration()).build()
self.trigger = TriggerBuilder.create().withId(trigger_name).withTypeUID(“core.SystemStartlevelTrigger”).withConfiguration(Configuration({

“startlevel”: “100”

})).build()
 pail_frank23:
I detected another issue with the triggers: StartupTrigger is not working properly. By modifing the StartupTrigger class (around line 720 in triggers.py) I got it working:
Replace

self.trigger = TriggerBuilder.create().withId(trigger_name).withTypeUID("jsr223.StartupTrigger").withConfiguration(Configuration()).build()
self.trigger = TriggerBuilder.create().withId(trigger_name).withTypeUID(“core.SystemStartlevelTrigger”).withConfiguration(Configuration({

“startlevel”: “100”

})).build()
Thank you. I have updated my version on github too.
 DerOetzi:
Thanks for the nice working version of this. But why don’t you open a PR for this to the official repo?
I am unsure whether an official fix may have already been prepared but not yet uploaded. It is also not quite polished. I commented out some things instead of removing them, and my replacement implementation is just a quick and dirty solution. I’d be happy to submit it as a PR if Scott wanted it.
              Thanks, yes I found them later on. It was not that easy to migrate everything from these deprecated libs.
Right now it seems that most of my rules are working… Only executeCommandLines seems to have problems, even with the new parameter list.
Also it seems for me that System started triggers won’t fire on system startup. Is this possible?
 rkrisi:
Also it seems for me that System started triggers won’t fire on system startup. Is this possible?
See above. I’ve pushed a new update that should fix the startup trigger, thanks to @pail_frank23

The only change was to triggers.py
              Yes this seems to work, thanks!
One last thing which is not working for me regarding Jython rules is executeCommandLine. Did you get this working? I can’t really get any useful info why it is not working. I have changed the parameters as suggested in docs and other posts, but none of them worked. Basically it returns instantly with ‘None’, not even waiting for the timeout.