You signed in with another tab or window.
Reload
to refresh your session.
You signed out in another tab or window.
Reload
to refresh your session.
You switched accounts on another tab or window.
Reload
to refresh your session.
By clicking “Sign up for GitHub”, you agree to our
terms of service
and
privacy statement
. We’ll occasionally send you account related emails.
Already on GitHub?
Sign in
to your account
The GitHub runner
windows-2019
has Docker installed, so you can build and push images with a workflow like this:
https://github.com/sixeyed/pi/blob/master/.github/workflows/build-windows.yaml
Would be great if this action supported Windows image builds on Windows runners.
nulano, KnicKnic, natalieparellano, chadsugithub, giuliov, jonahgeorge, davetapley, giggio, michaljurecko, mdeggies, and 23 more reacted with thumbs up emoji
nebuk89, ScottGuymer, davidmurdoch, nozo-moto, jurgen-weber-deltatre, and lancejpollard reacted with eyes emoji
All reactions
Hi
@sixeyed
, thanks for your feedback. This is interesting and I can see it being useful. Currently the action runs using a Linux container hence it wouldn't work with the Windows hosts so this will need some investigating on the best way to support this. I will discuss this with our PM and see if we can get it prioritized
FYI this is working with Windows
https://github.com/mr-smithers-excellent/docker-build-push
but hitting some issues on second push.
We have Linux images and Windows based images (for On prem customers).
Windows containers require a special treatment due to buildx not being compatible, yet.
Relates to docker/buildx#176
Relates to docker/build-push-action#18
Windows containers require a special treatment due to buildx not being compatible, yet.
Relates to docker/buildx#176
Relates to docker/build-push-action#18
## Description
Docker builds and smoke tests are only run on Linux machines as building docker containers on macOS and windows runners introduces complexity to the CI setup that we consider not worth the effort:
- macOS runners require the setup of [colima as a docker runtime](
actions/runner-images#6216
) which adds another 1.5-2m to the runtime
- on macOS testcontainers failed to detect the docker environment unless [additional environment variables](
https://www.testcontainers.org/features/configuration/#customizing-docker-host-detection
) have been set
- some docker related actions are not supported on windows runners like [`docker/build-push-action`](
docker/build-push-action#18 (comment)
)
- the docker setup on Githubs windows runners seems to be bound to the `windows/amd64` platform, see e.g. this [log](
https://github.com/camunda/zeebe/actions/runs/3500015748/jobs/5862231609
)
Usage of native arm64 runners is listed as a separate sub-task on
#10986
.
## Related issues
closes
#11020
Co-authored-by: Meggle (Sebastian Bathke) <
[email protected]>
Co-authored-by: Sebastian Bathke (Meggle) <
[email protected]>