reference to 'thread' is ambiguous · Issue #243 · facebook/folly

link管理

链接快照平台

输入网页链接，自动生成快照
标签化管理网页链接

相关文章推荐

酒量小的小蝌蚪 · 《拾又之国》：中日合拍两开花？_百科TA说· 1 年前 ·

安静的包子 · 印度西部22人确诊感染寨卡病毒-新华网· 1 年前 ·

纯真的柑橘 · 冠通出席2021跨境电商海外仓分销平台专场活 ...· 1 年前 ·

唠叨的卡布奇诺 · 93岁白雪仙为任剑辉办107岁冥寿生日会，3 ...· 1 年前 ·

痴情的可乐 · 汤加(大洋洲国家)_搜狗百科· 1 年前 ·

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

➜  folly git:(master) make
libtool: compile:  g++ -DHAVE_CONFIG_H -I./.. -pthread -I/usr/local/include -std=gnu++0x -g -O2 -MT io/async/ScopedEventBaseThread.lo -MD -MP -MF io/async/.deps/ScopedEventBaseThread.Tpo -c io/async/ScopedEventBaseThread.cpp  -fno-common -DPIC -o io/async/.libs/ScopedEventBaseThread.o
io/async/ScopedEventBaseThread.cpp:47:25: error: reference to 'thread' is ambiguous
  thread_ = make_unique<thread>(&EventBase::loopForever, &*eventBase_);
./../folly/io/async/ScopedEventBaseThread.h:23:7: note: candidate found by name lookup is
      'std::thread'
class thread;
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/thread:259:24: note:
      candidate found by name lookup is 'std::__1::thread'
class _LIBCPP_TYPE_VIS thread
io/async/ScopedEventBaseThread.cpp:47:25: error: reference to 'thread' is ambiguous
  thread_ = make_unique<thread>(&EventBase::loopForever, &*eventBase_);
./../folly/io/async/ScopedEventBaseThread.h:23:7: note: candidate found by name lookup is
      'std::thread'
class thread;
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/thread:259:24: note:
      candidate found by name lookup is 'std::__1::thread'
class _LIBCPP_TYPE_VIS thread
io/async/ScopedEventBaseThread.cpp:56:10: error: member access into incomplete type 'std::thread'
  thread_->join();
./../folly/io/async/ScopedEventBaseThread.h:23:7: note: forward declaration of 'std::thread'
class thread;
In file included from io/async/ScopedEventBaseThread.cpp:17:
In file included from ./../folly/io/async/ScopedEventBaseThread.h:19:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/memory:2429:27: error:
      invalid application of 'sizeof' to an incomplete type 'std::thread'
            static_assert(sizeof(_Tp) > 0, "default_delete can not delete incomplete type");
                          ^~~~~~~~~~~
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/memory:2630:13: note:
      in instantiation of member function 'std::__1::default_delete<std::thread>::operator()'
      requested here
            __ptr_.second()(__tmp);
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/memory:2598:46: note:
      in instantiation of member function 'std::__1::unique_ptr<std::thread,
      std::__1::default_delete<std::thread> >::reset' requested here
    _LIBCPP_INLINE_VISIBILITY ~unique_ptr() {reset();}
io/async/ScopedEventBaseThread.cpp:26:24: note: in instantiation of member function
      'std::__1::unique_ptr<std::thread, std::__1::default_delete<std::thread> >::~unique_ptr'
      requested here
ScopedEventBaseThread::ScopedEventBaseThread(bool autostart) {
./../folly/io/async/ScopedEventBaseThread.h:23:7: note: forward declaration of 'std::thread'
class thread;
In file included from io/async/ScopedEventBaseThread.cpp:20:
./../folly/Memory.h:43:37: error: allocation of incomplete type 'std::thread'
  return std::unique_ptr<T, Dp>(new T(std::forward<Args>(args)...));
io/async/ScopedEventBaseThread.cpp:47:13: note: in instantiation of function template specialization
      'folly::make_unique<std::thread, std::__1::default_delete<std::thread>, void
      (folly::EventBase::*)(), folly::EventBase *>' requested here
  thread_ = make_unique<thread>(&EventBase::loopForever, &*eventBase_);
./../folly/io/async/ScopedEventBaseThread.h:23:7: note: forward declaration of 'std::thread'
class thread;
5 errors generated.
make[2]: *** [io/async/ScopedEventBaseThread.lo] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2
➜  folly git:(master) g++ -v
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 6.1.0 (clang-602.0.53) (based on LLVM 3.6.0svn)
Target: x86_64-apple-darwin14.3.0
Thread model: posix
osx 10.10.3

https://github.com/facebook/flint/issues/32
          I'm not sure exactly what's going on, but the problem is that forward-declaring std::thread in the header and then doing #include <thread> in the implementation file, is not working with OSX's toolchain. The solution is to replace the forward declaration with #include <thread>
diff --git a/folly/io/async/ScopedEventBaseThread.h b/folly/io/async/ScopedEventBaseThread.h
index 60d62d7..fa35f35 100644
--- a/folly/io/async/ScopedEventBaseThread.h
+++ b/folly/io/async/ScopedEventBaseThread.h
@@ -17,12 +17,9 @@
 #pragma once
 #include <memory>
+#include <thread>
 #include <folly/io/async/EventBase.h>
-namespace std {
-class thread;
 namespace folly {
I will fix this, but you can make the simple change immediately to get unblocked.
      Summary: This fixes github issue #243
I don't understand why this is broken on osx, but the solution is to just `#include <thread>` in the header instead of trying to forward declare `std::thread`.
Reviewed By: @yfeldblum
Differential Revision: D2255026