47 bytes, text/x-phabricator-request

It helps clang-format-8 to know if they should be considered as function
https://reviews.llvm.org/D33440

StatementMacros: [MARKUPMAP, ASSERT_TRUE, ASSERT_FALSE, TEST, CHECK]

Attached file Bug 1542146 - Apply the change with the option StatementMacros from clang-format-8 r?andi — Details

ignore-this-changeset

Depends on D26279

Pushed by [email protected]:
https://hg.mozilla.org/integration/autoland/rev/55ed5f885d52
Use the new option StatementMacros from clang-format-8 r=andi
https://hg.mozilla.org/integration/autoland/rev/6f723cac81dd
Apply the change with the option StatementMacros from clang-format-8 r=andi

https://hg.mozilla.org/mozilla-central/rev/55ed5f885d52
https://hg.mozilla.org/mozilla-central/rev/6f723cac81dd

Status: NEW → RESOLVED

Closed: 4 years ago

status-firefox68 : --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla68

If you're reading this bug because you're now getting unknown key 'StatementMacros' error messages when you try to hg commit: you need to re-run ./mach bootstrap to get the latest clang-format.

YAML:28:19: error: unknown key 'StatementMacros'
StatementMacros: [MARKUPMAP, ASSERT_TRUE, ASSERT_FALSE, TEST, CHECK]

I am not sure why the new version of clang-format isn't downloaded immediately :/ Andi, any idea why? Thanks


       Flags: needinfo?(bpostelnicu)

Yes it's the same thing that we have with clang-tidy based analysis, we don't have a setup that detects that the artifact is newer than what we have locally in order to begin the update process. This was one of the reasons why we've added clang-tidy package to bootstrap , but this is sub-optimal so I've opened bug 1542694 for this.


       Flags:
       
        needinfo?(bpostelnicu)

I feel the need to add some clarifications here:


      
       ~/.mozbuild/clang represents the artifact for the compiler
      
      
       ~/.mozbuild/clang-tools/clang-tidy represents the artifact for clang based static analysis, like clang-tidy and for formatting, clang-format
      
      
       The artifacts that we download, ex. clang-tidy and clang are tied up with the version of the tree that we are using, so in order to get the latest artifacts you need to be on he head of the mozilla-central.

(In reply to Andi-Bogdan Postelnicu [:andi] from comment #12 )


      
       The artifacts that we download, ex. clang-tidy and clang are tied up with the version of the tree that we are using, so in order to get the latest artifacts you need to be on he head of the mozilla-central.
      
      
       Apologies for starting to veer off topic, but this makes me wonder: is it then possible to get into a situation where you'd like to do development simultaneously on e.g. a central tree and a beta tree, but you can't because they share the
       
        .mozbuild
       
       artifacts and they require different versions of them?